chore: Refactor location parameter usage in main.bicep#209
Open
Shreyas-Microsoft wants to merge 5 commits intodevfrom
Open
chore: Refactor location parameter usage in main.bicep#209Shreyas-Microsoft wants to merge 5 commits intodevfrom
Shreyas-Microsoft wants to merge 5 commits intodevfrom
Conversation
Updated location parameter references and descriptions for various resources.
Shreyas-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Removed duplicate parameters for AI service location.
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Removed duplicate azureAiServiceLocation parameter.
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Replaced references to 'solutionLocation' with 'location' for consistency across modules.
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Shreyas-Microsoft
had a problem deploying
to
production
GitHub Actions
Failure
VishalS-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
VishalS-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
VishalS-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated location parameter references and descriptions for various resources.
Purpose
This pull request simplifies and unifies the handling of Azure region parameters in the
infra/main.bicepfile. The key change is the consistent use of thelocationparameter for resource deployment, replacing previous usage ofsolutionLocationandcosmosLocationvariables. Additionally, the Cosmos DB and AI deployment location parameters have been cleaned up for clarity.Parameter and variable simplification:
locationparameter description to include Cosmos DB and removed the unnecessarysolutionLocationvariable, ensuring all resources use the same region parameter.cosmosLocationparameter and ensured Cosmos DB resources use the mainlocationparameter. [1] [2]Resource module updates:
locationparameter instead ofsolutionLocationorcosmosLocation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Parameter cleanup:
aiDeploymentLocationparameter and its allowed values, consolidating AI service location handling.These changes make the infrastructure code more maintainable and reduce the risk of region mismatches between resources.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information